Trilogy of Errors August 30th, 2007

def formatted_value(value)
    return value.split("\n").join("<BR>") if !value.nil?
    return value
end

This method:

  1. Has a vague name.
  2. Is overly complicated.
  3. Generates invalid XML.

Refactored, you get:

def with_newlines_as_break_tags(value)
    value.to_s.gsub("\n", "<br />") if value
end